Re: [LTP] [PATCH] syscalls/ptrace10: Add new regression test

[Martin Doucha]

Hi,
the code looks good, though it might make sense to simply integrate the
check into ptrace08. Just 6 extra lines in the existing test should
achieve the same coverage.

It also seems the bug existed long before the CVE 2018-1000199 fix
because the test fails on vulnerable kernels as well.

Anyway, if you prefer to keep the patch as is:

Reviewed-by: Martin Doucha <mdoucha@xxxxxxx>

On 04. 09. 20 20:00, Cyril Hrubis wrote:
> New regression test for a kernel commit:
> 
> commit bd14406b78e6daa1ea3c1673bda1ffc9efdeead0
> Author: Jiri Olsa <jolsa@xxxxxxxxxx>
> Date:   Mon Aug 27 11:12:25 2018 +0200
> 
>     perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set
> 
> Signed-off-by: Cyril Hrubis <chrubis@xxxxxxx>
> CC: Andy Lutomirski <luto@xxxxxxxxxx>
> CC: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CC: Alexandre Chartre <alexandre.chartre@xxxxxxxxxx>
> ---


-- 
Martin Doucha   mdoucha@xxxxxxx
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic