Re: [PATCH 03/12] MIPS/jazzdma: decouple from dma-direct

From: Christoph Hellwig
Date: Fri Sep 11 2020 - 03:07:40 EST


On Thu, Sep 10, 2020 at 10:12:33PM +0800, Hillf Danton wrote:
>
> On Tue, 8 Sep 2020 18:47:49 +0200 Christoph Hellwig wrote:
> >
> > The jazzdma ops implement support for a very basic IOMMU. Thus we really
> > should not use the dma-direct code that takes physical address limits
> > into account. This survived through the great MIPS DMA ops cleanup mostly
> > because I was lazy, but now it is time to fully split the implementations.
>
> A minor change in behavior, do we need to clear the dma buf as the
> dma-direct code does?

Yes, I've fixed this up.