Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'

From: Hyun Kwon
Date: Thu Sep 10 2020 - 14:16:49 EST


Hi Jason,

On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote:
> This addresses the following gcc warning with "make W=1":
>
> drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
> ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=]
> 245 | static const u32 scaling_factors_666[] = {
> | ^~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>

Reviewed-by: Hyun Kwon <hyun.kwon@xxxxxxxxxx>

Thanks!

-hyun

> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index a455cfc1bee5..98bd48f13fd1 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = {
> ZYNQMP_DISP_AV_BUF_5BIT_SF,
> };
>
> -static const u32 scaling_factors_666[] = {
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> -};
> -
> static const u32 scaling_factors_888[] = {
> ZYNQMP_DISP_AV_BUF_8BIT_SF,
> ZYNQMP_DISP_AV_BUF_8BIT_SF,
> --
> 2.25.4
>