Re: [PATCH net-next v7 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

[Andy Shevchenko]

On Thu, Sep 10, 2020 at 11:25 AM Vadym Kochan <vadym.kochan@xxxxxxxxxxx> wrote:
> On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan <vadym.kochan@xxxxxxxxxxx> wrote:


> > > +               .param = {.admin_state = admin_state}
> >
> > + white spaces? Whatever you choose, just be consistent among all
> > similar definitions.
> >
>
> Can I use following format for one-liner embedded struct ?

Of course. It's just a style matter.
My point that you need to be consistent over all similar cases in the code.

>         .param = {
>                 .admin_state = admin_state,
>         }
> > ...
> >
>
> I think it looks better when all of the members filled looks similar
> (even if it requires 2 additional lines) instead of having:
>
>     .member = { E } ?

I like the former one (as you do), but in some cases when you have one
member or an array it's convenient to have them one one line.

-- 
With Best Regards,
Andy Shevchenko