Re: [PATCH] platform/chrome: Don't populate lightbar device if it isn't there

[Stephen Boyd]

Quoting Guenter Roeck (2020-09-09 13:48:41)
> On Wed, Sep 9, 2020 at 1:26 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> > -static int get_lightbar_version(struct cros_ec_dev *ec,
> > -                               uint32_t *ver_ptr, uint32_t *flg_ptr)
> > -{
> > -       struct ec_params_lightbar *param;
> > -       struct ec_response_lightbar *resp;
> > -       struct cros_ec_command *msg;
> > -       int ret;
> > -
> > -       msg = alloc_lightbar_cmd_msg(ec);
> > -       if (!msg)
> > -               return 0;
> > -
> > -       param = (struct ec_params_lightbar *)msg->data;
> > -       param->cmd = LIGHTBAR_CMD_VERSION;
> > -       ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
> > -       if (ret < 0) {
> 
> I am quite sure this conflicts against the patch series I submitted
> earlier, specifically "cros_ec_lightbar: Accept more error codes from
> cros_ec_cmd_xfer_status".

Thanks! A pointer to git commit would have been helpful to find it even
faster but I got it now. I'll rebase and resend.