Re: [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute

From: Rob Herring
Date: Tue Sep 08 2020 - 15:50:44 EST


On Mon, Sep 07, 2020 at 09:34:00AM +0200, Neil Armstrong wrote:
> The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd
> node like the axg-clkc node.
>
> Thus the reg attribute is not needed.

If the phy registers have an address then it should remain even if Linux
happens to not care. The exception is if the registers are all
interleaved with other stuff.

>
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> ---
> .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> index 18c1ec5e19ad..a9040aa387cf 100644
> --- a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> @@ -13,15 +13,11 @@ properties:
> compatible:
> const: amlogic,axg-mipi-pcie-analog-phy
>
> - reg:
> - maxItems: 1
> -
> "#phy-cells":
> const: 1
>
> required:
> - compatible
> - - reg
> - "#phy-cells"
>
> additionalProperties: false
> --
> 2.22.0
>