Re: [PATCH] genksyms: keywords: Use __restrict not _restrict

From: Nick Desaulniers
Date: Sat Aug 15 2020 - 17:57:31 EST


On Fri, Aug 14, 2020 at 6:38 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> Use the proper form of the RESTRICT keyword.
>
> Quote the comments properly too.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Acked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

(Surprised what looked to me like a typo compiled). Would a
checkpatch warning be helpful, too? What's KAO? Urban dictionary has
no entry. :^P

> ---
> scripts/genksyms/keywords.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/genksyms/keywords.c b/scripts/genksyms/keywords.c
> index 7a85c4e21175..057c6cabad1d 100644
> --- a/scripts/genksyms/keywords.c
> +++ b/scripts/genksyms/keywords.c
> @@ -25,9 +25,9 @@ static struct resword {
> { "__int128_t", BUILTIN_INT_KEYW },
> { "__uint128_t", BUILTIN_INT_KEYW },
>
> - // According to rth, c99 defines "_Bool", __restrict", __restrict__", "restrict". KAO
> + // According to rth, c99 defines "_Bool", "__restrict", "__restrict__", "restrict". KAO
> { "_Bool", BOOL_KEYW },
> - { "_restrict", RESTRICT_KEYW },
> + { "__restrict", RESTRICT_KEYW },
> { "__restrict__", RESTRICT_KEYW },
> { "restrict", RESTRICT_KEYW },
> { "asm", ASM_KEYW },
>


--
Thanks,
~Nick Desaulniers