Re: [PATCH] tools build feature: Quote CC and CXX for their arguments

From: Arnaldo Carvalho de Melo
Date: Thu Aug 13 2020 - 09:01:33 EST


Em Wed, Aug 12, 2020 at 07:31:32PM -0700, Tom Hebb escreveu:
> On Wed, Aug 12, 2020 at 3:15 PM Daniel Díaz <daniel.diaz@xxxxxxxxxx> wrote:
> > Makefile.config:414: *** No gnu/libc-version.h found, please install glibc-dev[el]. Stop.
> > Makefile.perf:230: recipe for target 'sub-make' failed
> > make[1]: *** [sub-make] Error 2
> > Makefile:69: recipe for target 'all' failed
> > make: *** [all] Error 2
> >
> > With CC and CXX quoted, some of those features are now detected.
> >
> > Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent")
> >
> > Signed-off-by: Daniel Díaz <daniel.diaz@xxxxxxxxxx>
>
> Whoops, I'm the one who introduced this issue. Fix looks good, thanks!
>
> Reviewed-by: Thomas Hebb <tommyhebb@xxxxxxxxx>
> Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent")

Thanks, applied.

- Arnaldo