Re: [PATCH 0/5] Some clean-ups for bio merge

From: Baolin Wang
Date: Tue Aug 11 2020 - 07:49:24 EST


Hi,

On Wed, Jul 29, 2020 at 11:28:32AM +0800, Baolin Wang wrote:
> Hi,
>
> There are some duplicated code when trying to merge bio from pluged list
> and software queue, thus this patch set did some clean-ups when merging
> a bio. Any comments are welcome. Thanks.

Any comments for this patch set? Thanks.

>
> Baolin Wang (5):
> block: Move bio merge related functions into blk-merge.c
> block: Remove redundant blk_mq_sched_allow_merge() validation
> block: Add a new helper to attempt to merge a bio
> block: Remove blk_mq_attempt_merge() function
> block: Remove __blk_mq_sched_bio_merge() helper
>
> block/blk-core.c | 156 -----------------------------------------------
> block/blk-merge.c | 168 +++++++++++++++++++++++++++++++++++++++++++++++++++
> block/blk-mq-sched.c | 64 ++++++--------------
> block/blk-mq-sched.h | 13 +---
> block/blk.h | 9 +++
> 5 files changed, 197 insertions(+), 213 deletions(-)
>
> --
> 1.8.3.1