Re: [PATCH] intel_soc_pmic_mrfld: simplify the return expression of intel_scu_ipc_dev_iowrite8()
From: Andy Shevchenko
Date: Mon Jul 27 2020 - 09:00:43 EST
On Mon, Jul 27, 2020 at 3:57 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Mon, 27 Jul 2020, Andy Shevchenko wrote:
> > On Mon, Jul 27, 2020 at 03:04:07AM +0000, Xu Wang wrote:
...
> > It's a bit more helpful in the original form in case to add some debugging.
>
> If you wish to add debugging, you'll have to add the extra line of
> code yourself. :)
True, that's why I'm not objecting the change.
> > It also keep it symmetrical with read() counterpart.
>
> Can this be fixed-up too?
How? Can you elaborate?
> > That said, I'm not objecting the change if Lee finds it good enough.
--
With Best Regards,
Andy Shevchenko