Re: [PATCH v5 3/6] arch/x86: Implement text_alloc() and text_free()
From: Ingo Molnar
Date: Fri Jul 24 2020 - 05:23:05 EST
* Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> +void text_free(void *region)
> +{
> + /*
> + * This memory may be RO, and freeing RO memory in an interrupt is not
> + * supported by vmalloc.
> + */
> + lockdep_assert_irqs_enabled();
> +
> + vfree(region);
Had to dig around a bit to find the source of this restriction. Might
make sense to clarify this comment to:
/*
* This memory may be read-only, and freeing VM_FLUSH_RESET_PERMS memory
* in an interrupt is not supported by vmalloc.
*/
Thanks,
Ingo