Re: [PATCH][next] Bluetooth: Use fallthrough pseudo-keyword

From: Gustavo A. R. Silva
Date: Wed Jul 08 2020 - 14:26:49 EST


On Wed, Jul 08, 2020 at 06:49:39AM +0200, Marcel Holtmann wrote:
> Hi Gustavo,
>
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > fall-through markings when it is the case.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > ---
> > drivers/bluetooth/bcm203x.c | 2 +-
> > drivers/bluetooth/bluecard_cs.c | 2 --
> > drivers/bluetooth/hci_ll.c | 2 +-
> > drivers/bluetooth/hci_qca.c | 8 +-------
> > net/bluetooth/hci_event.c | 4 ++--
> > net/bluetooth/hci_sock.c | 3 +--
> > net/bluetooth/l2cap_core.c | 19 +++++++++----------
> > net/bluetooth/l2cap_sock.c | 4 ++--
> > net/bluetooth/mgmt.c | 4 ++--
> > net/bluetooth/rfcomm/core.c | 2 +-
> > net/bluetooth/rfcomm/sock.c | 2 +-
> > net/bluetooth/smp.c | 2 +-
> > 12 files changed, 22 insertions(+), 32 deletions(-)
>
> can we split these a little bit between drivers, core and rfcomm. Thanks.
>

Sure thing, no problem. I'll split this up and send again.

Thanks
--
Gustavo