Re: [PATCH] usbip: Use fallthrough pseudo-keyword

From: Joe Perches
Date: Tue Jul 07 2020 - 21:56:36 EST


On Tue, 2020-07-07 at 14:06 -0600, Shuah Khan wrote:
> On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote:
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > fall-through markings when it is the case.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> >
>
> Is fallthrough syntax supported on our min gcc version?

No. Introduced in gcc 7.

> Does checkpatch or coccicheck catch these cases?

Kinda. checkpatch isn't very good at it.
I _believe_, though I'm not at all sure,
that coccinelle can find these.