Re: [RFT PATCH] ia64: Fix build error with !COREDUMP

From: Krzysztof Kozlowski
Date: Tue Jul 07 2020 - 14:35:07 EST


On Thu, Jun 04, 2020 at 10:18:42PM +0200, Krzysztof Kozlowski wrote:
> Fix linkage error when CONFIG_BINFMT_ELF is selected but CONFIG_COREDUMP
> is not:
>
> ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_phdrs':
> elfcore.c:(.text+0x172): undefined reference to `dump_emit'
> ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_data':
> elfcore.c:(.text+0x2b2): undefined reference to `dump_emit'
>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Fixes: 1fcccbac89f5 ("elf coredump: replace ELF_CORE_EXTRA_* macros by functions")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> ---
>
> Please let kbuild test it for a while before applying. I built it only
> on few configurations.
>
> This is similar fix to commit 42d91f612c87 ("um: Fix build error and
> kconfig for i386") although I put different fixes tag - the commit which
> introduced this part of code.

Kernel-test-robot did not complain anymore so I think build tests
passed.

Any comments here?

Best regards,
Krzysztof