Re: [PATCH 1/9] usb: cdns3: Improvement: removed cdns3_get_current_role_driver function.

From: Peter Chen
Date: Tue Jul 07 2020 - 02:20:08 EST


On 20-07-01 08:19:56, Pawel Laszczak wrote:
> Function is not used in driver so it can be removed.
>
> Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx>
> ---
> drivers/usb/cdns3/core.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index 19bbb5b7e6b6..eaafa6bd2a50 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -27,13 +27,6 @@
>
> static int cdns3_idle_init(struct cdns3 *cdns);
>
> -static inline
> -struct cdns3_role_driver *cdns3_get_current_role_driver(struct cdns3 *cdns)
> -{
> - WARN_ON(!cdns->roles[cdns->role]);
> - return cdns->roles[cdns->role];
> -}
> -

Change the title for the patch, otherwise:
Reviewed-by: Peter Chen <peter.chen@xxxxxxx>

--

Thanks,
Peter Chen