Re: [PATCH] i2c: jz4780: remove redundant assignment to variable i

From: Paul Cercueil
Date: Mon Jul 06 2020 - 19:52:43 EST


Hi,

Le sam. 4 juil. 2020 à 8:32, Wolfram Sang <wsa@xxxxxxxxxx> a écrit :
On Wed, Jun 10, 2020 at 01:59:01PM +0100, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The variable i is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

What about 'ret'? Doesn't the same reasoning apply for it?


That's correct.

Colin, could you respin the patch and do the same for the 'ret' variable?

Thanks,
-Paul