Re: [PATCH v12 00/31] Speculative page faults

From: Laurent Dufour
Date: Mon Jul 06 2020 - 08:28:45 EST


Le 06/07/2020 Ã 11:25, Chinwen Chang a ÃcritÂ:
On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote:
Hi Laurent,

I downloaded your script and run it on Intel 2s skylake platform with spf-v12 patch
serials.

Here attached the output results of this script.

The following comparison result is statistics from the script outputs.

a). Enable THP
SPF_0 change SPF_1
will-it-scale.page_fault2.per_thread_ops 2664190.8 -11.7% 2353637.6
will-it-scale.page_fault3.per_thread_ops 4480027.2 -14.7% 3819331.9


b). Disable THP
SPF_0 change SPF_1
will-it-scale.page_fault2.per_thread_ops 2653260.7 -10% 2385165.8
will-it-scale.page_fault3.per_thread_ops 4436330.1 -12.4% 3886734.2


Thanks,
Haiyan Song


On Fri, Jun 14, 2019 at 10:44:47AM +0200, Laurent Dufour wrote:
Le 14/06/2019 Ã 10:37, Laurent Dufour a Ãcrit :
Please find attached the script I run to get these numbers.
This would be nice if you could give it a try on your victim node and share the result.

Sounds that the Intel mail fitering system doesn't like the attached shell script.
Please find it there: https://gist.github.com/ldu4/a5cc1a93f293108ea387d43d5d5e7f44

Thanks,
Laurent.


Hi Laurent,

We merged SPF v11 and some patches from v12 into our platforms. After
several experiments, we observed SPF has obvious improvements on the
launch time of applications, especially for those high-TLP ones,

# launch time of applications(s):

package version w/ SPF w/o SPF improve(%)
------------------------------------------------------------------
Baidu maps 10.13.3 0.887 0.98 9.49
Taobao 8.4.0.35 1.227 1.293 5.10
Meituan 9.12.401 1.107 1.543 28.26
WeChat 7.0.3 2.353 2.68 12.20
Honor of Kings 1.43.1.6 6.63 6.713 1.24

That's great news, thanks for reporting this!


By the way, we have verified our platforms with those patches and
achieved the goal of mass production.

Another good news!
For my information, what is your targeted hardware?

Cheers,
Laurent.