Re: [tip: x86/urgent] x86/entry/32: Fix XEN_PV build dependency

From: JÃrgen GroÃ
Date: Mon Jul 06 2020 - 00:24:17 EST


On 05.07.20 22:24, Andy Lutomirski wrote:


On Jul 5, 2020, at 12:44 PM, tip-bot2 for Ingo Molnar <tip-bot2@xxxxxxxxxxxxx> wrote:

ïThe following commit has been merged into the x86/urgent branch of tip:

Commit-ID: a4c0e91d1d65bc58f928b80ed824e10e165da22c
Gitweb: https://git.kernel.org/tip/a4c0e91d1d65bc58f928b80ed824e10e165da22c
Author: Ingo Molnar <mingo@xxxxxxxxxx>
AuthorDate: Sun, 05 Jul 2020 21:33:11 +02:00
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitterDate: Sun, 05 Jul 2020 21:39:23 +02:00

x86/entry/32: Fix XEN_PV build dependency

xenpv_exc_nmi() and xenpv_exc_debug() are only defined on 64-bit kernels,
but they snuck into the 32-bit build via <asm/identry.h>, causing the link
to fail:

ld: arch/x86/entry/entry_32.o: in function `asm_xenpv_exc_nmi':
(.entry.text+0x817): undefined reference to `xenpv_exc_nmi'

ld: arch/x86/entry/entry_32.o: in function `asm_xenpv_exc_debug':
(.entry.text+0x827): undefined reference to `xenpv_exc_debug'

Only use them on 64-bit kernels.

JÃrgen, can you queue a revert for when PV32 goes away?

Yes, will do.


Juergen