Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting

From: Rajendra Nayak
Date: Wed Jul 01 2020 - 07:21:19 EST



On 6/1/2020 11:26 AM, Rajendra Nayak wrote:

On 5/28/2020 1:06 AM, Rob Herring wrote:
On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
Add an optional power domain which when specified can be used for
setting the performance state of Venus.

Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
---
 Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
 Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
index 764affa..ac1ed64 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
@@ -25,12 +25,16 @@ properties:
ÂÂÂÂÂ maxItems: 1
ÂÂÂ power-domains:
-ÂÂÂ maxItems: 2
+ÂÂÂ minItems: 2
+ÂÂÂ maxItems: 3
ÂÂÂ power-domain-names:
+ÂÂÂ minItems: 2
+ÂÂÂ maxItems: 3
ÂÂÂÂÂ items:
ÂÂÂÂÂÂÂ - const: venus
ÂÂÂÂÂÂÂ - const: vcodec0
+ÂÂÂÂÂ - const: opp-pd

Humm, looks suspicious. This is a phyical power island in this block?

yes, this is used to represent the physical 'cx' power island in the SoC
(Its a shared power island, not a power island specific to this block)
that can be scaled to different 'performance levels' based on the frequency
the codec is expected to run at.

Rob, Did you have any other concerns here? Should I be re-posting this?

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation