Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak

[Markus Elfring]

> In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
> was not released in the error case. Thus add jump target for the completion
> of the desired exception handling.

Another small wording adjustment:
  â Thus add a jump target â


â
> +++ b/drivers/irqchip/irq-xilinx-intc.c
â
> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
>
>  	return 0;
>
> +error_domain_remove:
> +	irq_domain_remove(irqc->root_domain);
>  error:
>  	iounmap(irqc->base);
â

Can labels like âremove_irq_domainâ and âunmap_ioâ be nicer?

Regards,
Markus