Re: [RFC PATCH 0/4] DirectX on Linux

From: Sasha Levin
Date: Tue Jun 16 2020 - 09:28:23 EST


On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote:
Hi!

> The driver creates the /dev/dxg device, which can be opened by user mode
> application and handles their ioctls. The IOCTL interface to the driver
> is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl
> definitions). The interface matches the D3DKMT interface on Windows.
> Ioctls are implemented in ioctl.c.

Echoing what others said, you're not making a DRM driver. The driver should live outside
of the DRM code.


Actually, this sounds to me like "this should not be merged into linux kernel". I mean,
we already have DRM API on Linux. We don't want another one, do we?

This driver doesn't have any display functionality.

And at the very least... this misses API docs for /dev/dxg. Code can't really
be reviewed without that.

The docs live here: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/d3dkmthk/

--
Thanks,
Sasha