Re: [PATCH v6 0/5] Add support for DisplayPort driver on

[tanmay]

On 2020-06-12 16:26, Stephen Boyd wrote:

Thanks for reviews Stephen.

> Quoting Tanmay Shah (2020-06-11 18:50:25)
> > These patches add support for Display-Port driver on SnapDragon
> > hardware. It adds
> > DP driver and DP PLL driver files along with the needed device-tree
> > bindings.
> >
> > The block diagram of DP driver is shown below:
> >
> >
> >                  +-------------+
> >                  |DRM FRAMEWORK|
> >                  +------+------+
> >                         |
> >                    +----v----+
> >                    | DP DRM  |
> >                    +----+----+
> >                         |
> >                    +----v----+
> >      +------------+|   DP    +----------++------+
> >      +        +---+| DISPLAY |+---+      |      |
> >      |        +    +-+-----+-+    |      |      |
> >      |        |      |     |      |      |      |
> >      |        |      |     |      |      |      |
> >      |        |      |     |      |      |      |
> >      v        v      v     v      v      v      v
> >  +------+ +------+ +---+ +----+ +----+ +---+ +-----+
> >  |  DP  | |  DP  | |DP | | DP | | DP | |DP | | DP  |
> >  |PARSER| | HPD  | |AUX| |LINK| |CTRL| |PHY| |POWER|
> >  +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+
> >     |                              |     |
> >  +--v---+                         +v-----v+
> >  |DEVICE|                         |  DP   |
> >  | TREE |                         |CATALOG|
> >  +------+                         +---+---+
> >                                       |
> >                                   +---v----+
> >                                   |CTRL/PHY|
> >                                   |   HW   |
> >                                   +--------+
>
> I've never seen a block diagram for a driver before...
It is here for v5. https://patchwork.freedesktop.org/series/74312/

> > These patches have dependency on clock driver changes mentioned below:
> > https://patchwork.kernel.org/patch/11245895/
> > https://patchwork.kernel.org/cover/11069083/
>
> These are merged right? Don't need to include this if it's already
> merged.
Ok Thanks.

> Can you include a changelog in the cover letter too so we know what has
> changed between versions of the patchset?
Sure.
> > Chandan Uddaraju (4):
> >   dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon
> >   drm: add constant N value in helper file
> >   drm/msm/dp: add displayPort driver support
> >   drm/msm/dp: add support for DP PLL driver
> >
> > Jeykumar Sankaran (1):
> >   drm/msm/dpu: add display port support in DPU
> [...]
> > base-commit: 48f99181fc118d82dc8bf6c7221ad1c654cb8bc2
>
> What is this commit? I don't see it in linux-next.
Here: 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200603&id=48f99181fc118d82dc8bf6c7221ad1c654cb8bc2