Re: [PATCH v2] iommu/tegra-smmu: Add missing locks around mapping operations

From: Dmitry Osipenko
Date: Mon Jun 15 2020 - 12:32:18 EST


25.05.2020 22:54, Dmitry Osipenko ÐÐÑÐÑ:
> The mapping operations of the Tegra SMMU driver are subjected to a race
> condition issues because SMMU Address Space isn't allocated and freed
> atomically, while it should be. This patch makes the mapping operations
> atomic, it fixes an accidentally released Host1x Address Space problem
> which happens while running multiple graphics tests in parallel on
> Tegra30, i.e. by having multiple threads racing with each other in the
> Host1x's submission and completion code paths, performing IOVA mappings
> and unmappings in parallel.
>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
>
> Changelog:
>
> v2: - Now using mutex instead of spinlock.
>
> - The _locked postfix is replaced with the underscores prefix.
>

Hello Thierry and Joerg!

Guys, are you okay with the v2 variant? Will be great if we could fix
the issue ASAP since it's quite unpleasant. Thanks in advance!