Re: [PATCH 0/8] x86/entry: KCSAN/KASAN/UBSAN vs noinstr

From: Peter Zijlstra
Date: Mon Jun 15 2020 - 11:06:51 EST


On Mon, Jun 15, 2020 at 10:57:18AM -0400, Qian Cai wrote:
> On Mon, Jun 15, 2020 at 12:07:34PM +0200, 'Marco Elver' via kasan-dev wrote:
> > On Thu, 4 Jun 2020 at 13:01, Marco Elver <elver@xxxxxxxxxx> wrote:
> > >
> > > On Thu, 4 Jun 2020 at 12:25, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > > >
> > > > Hai,
> > > >
> > > > Here's the remaining few patches to make KCSAN/KASAN and UBSAN work with noinstr.
> > >
> > > Thanks for assembling the series!
> > >
> > > For where it's missing (1,2,3 and last one):
> > >
> > > Acked-by: Marco Elver <elver@xxxxxxxxxx>
> >
> > Where was this series supposed to go? I can't find it on any tree yet.
> >
> > How urgent is this? Boot-test seems fine without this, but likely
> > doesn't hit the corner cases. Syzbot will likely find them, and if we
> > noticeably end up breaking various sanitizers without this, I'd
> > consider this urgent.
>
> Today's linux-next had a lot of those with this .config,
>
> https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config
>
> Wondering if this patchset will cure them all?

Many, not all, you also need:

https://lkml.kernel.org/r/20200603114051.896465666@xxxxxxxxxxxxx

and then I think you're down to only 1 kasan thing. But also read this
thread:

https://lkml.kernel.org/r/20200611215812.GF4496@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

latest version of that actual patch here:

https://lkml.kernel.org/r/20200612143034.933422660@xxxxxxxxxxxxx