Re: [PATCH] drm/mediatek: remove unnecessary conversion to bool

[Chun-Kuang Hu]

Joe Perches <joe@xxxxxxxxxxx> æ 2020å6æ15æ éä äå4:41åéï
>
> On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote:
> > In function mtk_dsi_clk_hs_state, remove unnecessary conversion
> > to bool return, this change is to make the code a bit readable.
> []
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> []
> > @@ -319,7 +319,7 @@ static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi)
> >       u32 tmp_reg1;
> >
> >       tmp_reg1 = readl(dsi->regs + DSI_PHY_LCCON);
> > -     return ((tmp_reg1 & LC_HS_TX_EN) == 1) ? true : false;
> > +     return ((tmp_reg1 & LC_HS_TX_EN) == 1);
>
> Given:
>
> drivers/gpu/drm/mediatek/mtk_dsi.c:#define LC_HS_TX_EN                  BIT(0)
>
> This is likely clearer as
>
>         return tmp_reg1 & LC_HS_TX_EN;
>
> or even
>
> static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi)
> {
>         return readl(dsi->regs + DSI_PHY_LCCON) & LC_HS_TX_EN;
> }

I like the second one.

>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel