Re: [PATCH 05/13] fs: check FMODE_WRITE in __kernel_write

From: Christoph Hellwig
Date: Mon Jun 15 2020 - 09:48:11 EST


On Mon, Jun 15, 2020 at 05:34:39AM -0700, Matthew Wilcox wrote:
> On Mon, Jun 15, 2020 at 02:12:49PM +0200, Christoph Hellwig wrote:
> > We still need to check if the fÑ is open write, even for the low-level
> > helper.
>
> Do we need the analogous check for FMODE_READ in the __kernel_read()
> patch?

Yes, we should probably grow it. Hoping that none of the caller
actually wants to mess with files not open for reading as some of them
are rather dodgy.