Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

From: Andy Shevchenko
Date: Mon Jun 15 2020 - 05:57:35 EST


On Tue, Jun 02, 2020 at 11:55:15AM -0700, Tony Lindgren wrote:
> * Tony Lindgren <tony@xxxxxxxxxxx> [200602 13:38]:
> > * Andy Shevchenko <andy.shevchenko@xxxxxxxxx> [200602 08:33]:
> > Now that we can detach and reattach the kernel serial console,
> > there should not be any need for pm_runtime_irq_safe() anymore :)
>
> Below is a hastily tested RFC patch to remove pm_runtime_irq_safe()
> for 8250_omap.c that seems to work for idle use case :)
>
> > And the UART wake-up from deeper idle states can only happen with
> > help of external hardware like GPIO controller or pinctrl controller.
>
> It does not yet include the check for configured wakeirq though.
> And omap-serial.c needs a similar patch or maybe we can attempt
> to just drop it this time as 8250_omap.c should be used nowadays.
> Or just drop PM from omap-serial.c if it can't be dropped.
>
> Andy, is the change below the only remaining blocker now for
> your serial PM runtime changes?

In private chat we have got more or less working solution. We both will going
to give more tests and then I will share (at least as a branch on some public
Git service) the set.

--
With Best Regards,
Andy Shevchenko