drivers/video/fbdev/core/fbmem.c:803:39: sparse: sparse: incorrect type in argument 2 (different address spaces)

From: kernel test robot
Date: Mon Jun 15 2020 - 03:41:45 EST

Next message:
Previous message: Messages sorted by:
tree: .config.gz Description: application/gzip Dmitry Vyukov: "Re: [RFC][PATCH 3/3] objtool: Fix noinstr vs KCOV" href="07571.html"> Pavel Machek: "Re: Re: [PATCH v4 0/2] Recommend denylist/allowlist instead of blacklist/whitelist" href="date.html#07572">[ date ] [ thread ] [ subject ] [ author ] .org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> kbuild: tell sparse about the $ARCH
as .config)
rty
1280c4a38f
build tree
-D__CHECK_ENDIAN__'
tag as appropriate
;
> sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const *s @@ got unsigned char [noderef] [usertype] <asn:2> *[assigned] src @@
expected void const *s
got unsigned char [noderef] [usertype] <asn:2> *[assigned] src
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *d @@ got unsigned char [noderef] [usertype] <asn:2> *[assigned] dst @@
expected void *d
got unsigned char [noderef] [usertype] <asn:2> *[assigned] dst
2011-05-11 756
2011-05-11 757 static ssize_t
2011-05-11 758 fb_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
2011-05-11 759 {
2011-05-11 760 unsigned long p = *ppos;
2011-05-11 761 struct fb_info *info = file_fb_info(file);
2010-10-27 762 u8 *buffer, *dst;
2010-10-27 763 u8 __iomem *src;
2010-10-27 764 int c, cnt = 0, err = 0;
2005-04-16 765 unsigned long total_size;
2005-04-16 766
2005-04-16 767 if (!info || ! info->screen_base)
2005-04-16 768 return -ENODEV;
2005-04-16 769
2005-04-16 770 if (info->state != FBINFO_STATE_RUNNING)
2005-04-16 771 return -EPERM;
2005-04-16 772
2005-04-16 773 if (info->fbops->fb_read)
A. Daplas 2007-05-08 774 return info->fbops->fb_read(info, buf, count, ppos);
2005-04-16 775
2005-04-16 776 total_size = info->screen_size;
A. Daplas 2006-01-09 777
2005-04-16 778 if (total_size == 0)
2005-04-16 779 total_size = info->fix.smem_len;
2005-04-16 780
2005-04-16 781 if (p >= total_size)
2005-04-16 782 return 0;
A. Daplas 2006-01-09 783
2005-04-16 784 if (count >= total_size)
2005-04-16 785 count = total_size;
A. Daplas 2006-01-09 786
2005-04-16 787 if (count + p > total_size)
2005-04-16 788 count = total_size - p;
2005-04-16 789
2005-04-16 790 buffer = kmalloc((count > PAGE_SIZE) ? PAGE_SIZE : count,
2005-04-16 791 GFP_KERNEL);
2005-04-16 792 if (!buffer)
2005-04-16 793 return -ENOMEM;
2005-04-16 794
2010-10-27 795 src = (u8 __iomem *) (info->screen_base + p);
2005-04-16 796
2005-04-16 797 if (info->fbops->fb_sync)
2005-04-16 798 info->fbops->fb_sync(info);
2005-04-16 799
2005-04-16 800 while (count) {
2005-04-16 801 c = (count > PAGE_SIZE) ? PAGE_SIZE : count;
2005-04-16 802 dst = buffer;
2010-10-27 @803 fb_memcpy_fromfb(dst, src, c);
2010-10-27 804 dst += c;
2010-10-27 805 src += c;
2005-04-16 806
2005-04-16 807 if (copy_to_user(buf, buffer, c)) {
2005-04-16 808 err = -EFAULT;
2005-04-16 809 break;
2005-04-16 810 }
2005-04-16 811 *ppos += c;
2005-04-16 812 buf += c;
2005-04-16 813 cnt += c;
2005-04-16 814 count -= c;
2005-04-16 815 }
2005-04-16 816
2005-04-16 817 kfree(buffer);
A. Daplas 2006-01-09 818
2005-04-16 819 return (err) ? err : cnt;
2005-04-16 820 }
2005-04-16 821
2005-04-16 822 static ssize_t
2005-04-16 823 fb_write(struct file *file, const char __user *buf, size_t count, loff_t *ppos)
2005-04-16 824 {
2005-04-16 825 unsigned long p = *ppos;
2011-05-11 826 struct fb_info *info = file_fb_info(file);
2010-10-27 827 u8 *buffer, *src;
2010-10-27 828 u8 __iomem *dst;
2010-10-27 829 int c, cnt = 0, err = 0;
2005-04-16 830 unsigned long total_size;
2005-04-16 831
2005-04-16 832 if (!info || !info->screen_base)
2005-04-16 833 return -ENODEV;
2005-04-16 834
2005-04-16 835 if (info->state != FBINFO_STATE_RUNNING)
2005-04-16 836 return -EPERM;
2005-04-16 837
2005-04-16 838 if (info->fbops->fb_write)
A. Daplas 2007-05-08 839 return info->fbops->fb_write(info, buf, count, ppos);
2005-04-16 840
2005-04-16 841 total_size = info->screen_size;
A. Daplas 2006-01-09 842
2005-04-16 843 if (total_size == 0)
2005-04-16 844 total_size = info->fix.smem_len;
2005-04-16 845
2005-04-16 846 if (p > total_size)
A. Daplas 2006-04-18 847 return -EFBIG;
A. Daplas 2006-01-09 848
A. Daplas 2006-04-18 849 if (count > total_size) {
A. Daplas 2006-04-18 850 err = -EFBIG;
2005-04-16 851 count = total_size;
A. Daplas 2006-04-18 852 }
A. Daplas 2006-04-18 853
A. Daplas 2006-04-18 854 if (count + p > total_size) {
A. Daplas 2006-04-18 855 if (!err)
A. Daplas 2006-04-18 856 err = -ENOSPC;
A. Daplas 2006-01-09 857
2005-04-16 858 count = total_size - p;
A. Daplas 2006-04-18 859 }
A. Daplas 2006-01-09 860
2005-04-16 861 buffer = kmalloc((count > PAGE_SIZE) ? PAGE_SIZE : count,
2005-04-16 862 GFP_KERNEL);
2005-04-16 863 if (!buffer)
2005-04-16 864 return -ENOMEM;
2005-04-16 865
2010-10-27 866 dst = (u8 __iomem *) (info->screen_base + p);
2005-04-16 867
2005-04-16 868 if (info->fbops->fb_sync)
2005-04-16 869 info->fbops->fb_sync(info);
2005-04-16 870
2005-04-16 871 while (count) {
2005-04-16 872 c = (count > PAGE_SIZE) ? PAGE_SIZE : count;
2005-04-16 873 src = buffer;
A. Daplas 2006-01-09 874
2005-04-16 875 if (copy_from_user(src, buf, c)) {
2005-04-16 876 err = -EFAULT;
2005-04-16 877 break;
2005-04-16 878 }
A. Daplas 2006-01-09 879
2010-10-27 @880 fb_memcpy_tofb(dst, src, c);
2010-10-27 881 dst += c;
2010-10-27 882 src += c;
2005-04-16 883 *ppos += c;
2005-04-16 884 buf += c;
2005-04-16 885 cnt += c;
2005-04-16 886 count -= c;
2005-04-16 887 }
A. Daplas 2006-01-09 888
2005-04-16 889 kfree(buffer);
2005-04-16 890
A. Daplas 2006-04-18 891 return (cnt) ? cnt : err;
2005-04-16 892 }
2005-04-16 893
by commit
fbmem: fix fb_read, fb_write unaligned accesses
br> xxxxxxxx>
kitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
- Next message: Dmitry Vyukov: "Re: [RFC][PATCH 3/3] objtool: Fix noinstr vs KCOV"
- Previous message: Pavel Machek: "Re: Re: [PATCH v4 0/2] Recommend denylist/allowlist instead of blacklist/whitelist"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]