Re: [patch for-5.8 2/4] dma-direct: re-encrypt memory if dma_direct_alloc_pages() fails

From: Christoph Hellwig
Date: Mon Jun 15 2020 - 02:56:30 EST


On Thu, Jun 11, 2020 at 12:20:29PM -0700, David Rientjes wrote:
> If arch_dma_set_uncached() fails after memory has been decrypted, it needs
> to be re-encrypted before freeing.
>
> Fixes: fa7e2247c572 ("dma-direct: make uncached_kernel_address more
> general")
> Cc: stable@xxxxxxxxxxxxxxx # 5.7
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>

Note that this can't really happen in practice as
CONFIG_ARCH_HAS_DMA_SET_UNCACHED and memory encryption are mutally
exclusive in pracrie. Still looks ok and useful otherwise.