RE: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error

From: Aisheng Dong
Date: Mon Jun 15 2020 - 02:33:46 EST


> From: Wolfram Sang <wsa@xxxxxxxxxx>
> Sent: Sunday, June 14, 2020 5:12 PM
>
> On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even the
> > call returns an error code. Thus a corresponding decrement is needed
> > on the error handling path to keep the counter balanced.
>
> Can you point me to a discussion where it was decided that this is a proper fix?
> I'd think we rather should fix pm_runtime_get_sync() but maybe there are
> technical reasons against it.

I had the same feeling.
Copy pm guys to comments.

Regards
Aisheng