Re: [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set()

From: Zefan Li
Date: Sun Jun 14 2020 - 21:11:45 EST


On 2020/6/15 7:22, zzuedu2000@xxxxxxx wrote:
> On Sun, 2020-06-14 at 18:10 +0800, James.Bottomley@xxxxxxx wrote:
>
>> it's arguable that having two statements instead of one makes the code
>> marginally more readable.
>
> Above the function there is a similar line of code:
> l = it->tcset_pos->next;
> One line of code makes the code style consistent and more readable
>

It would be much better if you are fixing a bug or developing a new feature
and while at it you do this cleanup conveniently, but this patch alone has
little value.