Re: [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set()

From: James Bottomley
Date: Sun Jun 14 2020 - 14:10:40 EST


On Sun, 2020-06-14 at 10:28 +0800, zzuedu2000@xxxxxxx wrote:
> From: Wei Fenghai <zzuedu2000@xxxxxxx>
>
> Combine two assignments for the variable âlâ into one statement.

The problem with this commit message isn't the description, we can all
see what the change does, it's the justification. Why is there any
reason to do this? My version of gcc does this as an optimization
anyway, so the patch doesn't change to the binary output and it's
arguable that having two statements instead of one makes the code
marginally more readable.

Regards,

James