Re: [PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

From: Markus Elfring
Date: Sun Jun 14 2020 - 09:06:43 EST


> in amdgpu_display_crtc_set_config, â

* Can the term âreference countâ become relevant also for this commit message
besides other possible adjustments?

* Can it be nicer to combine proposed updates for this software module
as a patch series (with a cover letter)?

* Would you like to add the tag âFixesâ?


â
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
â
> @@ -306,6 +306,7 @@ int amdgpu_display_crtc_set_config(struct drm_mode_set *set,
> adev->have_disp_power_ref = false;
> }
>
> +out:
> /* drop the power reference we got coming in here */
> pm_runtime_put_autosuspend(dev->dev);
> return ret;

Perhaps use the label âput_runtimeâ instead?

Regards,
Markus