Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

From: Markus Elfring
Date: Sun Jun 14 2020 - 07:31:36 EST


> in panfrost_job_hw_submit, â

* Can the term âreference countâ become relevant also for this commit message
besides other possible adjustments?

* Would you like to add the tag âFixesâ?


â
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
â
> @@ -184,6 +183,9 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
> job, js, jc_head);
>
> job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
> +out:
> + pm_runtime_put_sync_autosuspend(pfdev->dev);
> + return;
> }
â

Perhaps use the label âput_syncâ instead?

Regards,
Markus