Re: [PATCH] xdp_rxq_info_user: Fix null pointer dereference. Replace malloc/memset with calloc.

From: John Fastabend
Date: Fri Jun 12 2020 - 18:58:19 EST


Jesper Dangaard Brouer wrote:
> On Fri, 12 Jun 2020 14:53:27 -0400
> Gaurav Singh <gaurav1086@xxxxxxxxx> wrote:
>
> > Memset on the pointer right after malloc can cause a
> > null pointer deference if it failed to allocate memory.
> > A simple fix is to replace malloc/memset with a calloc()
> >
> > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info")
> > Signed-off-by: Gaurav Singh <gaurav1086@xxxxxxxxx>
>
> Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
>

Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>