Re: [PATCH] coresight: cti: Fix error handling in probe

From: Dan Carpenter
Date: Fri Jun 12 2020 - 13:43:55 EST


On Fri, Jun 12, 2020 at 02:11:16PM +0000, Walter Harms wrote:
> Hi Dan,
>
> nit picking in cti_pm_release()
>
> IMHO this should be done in 2 steps:
> if (--nr_cti_cpu == 0)
> ->
> --nr_cti_cpu ;
> if ( nr_cti_cpu == 0)

The first way is sort of the more canonical way to write it... By far.

regards,
carpenter