RE: [PATCH v1 1/2] scsi: ufs: Remove unused field in struct uic_command

From: Alim Akhtar
Date: Fri Jun 12 2020 - 12:22:59 EST


Hi Stanley

> -----Original Message-----
> From: Stanley Chu <stanley.chu@xxxxxxxxxxxx>
> Sent: 12 June 2020 20:40
> To: linux-scsi@xxxxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx;
> avri.altman@xxxxxxx; alim.akhtar@xxxxxxxxxxx; jejb@xxxxxxxxxxxxx;
> asutoshd@xxxxxxxxxxxxxx
> Cc: beanhuo@xxxxxxxxxx; cang@xxxxxxxxxxxxxx; matthias.bgg@xxxxxxxxx;
> bvanassche@xxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kuohong.wang@xxxxxxxxxxxx; peter.wang@xxxxxxxxxxxx; chun-
> hung.wu@xxxxxxxxxxxx; andy.teng@xxxxxxxxxxxx;
> chaotian.jing@xxxxxxxxxxxx; cc.chou@xxxxxxxxxxxx; Stanley Chu
> <stanley.chu@xxxxxxxxxxxx>
> Subject: [PATCH v1 1/2] scsi: ufs: Remove unused field in struct
uic_command
>
> Remove unused field "cmd_active" in struct ufs_command.
>
> Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> drivers/scsi/ufs/ufshcd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index
> bf97d616e597..814e44871ff0 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -88,7 +88,6 @@ enum dev_cmd_type {
> * @argument1: UIC command argument 1
> * @argument2: UIC command argument 2
> * @argument3: UIC command argument 3
> - * @cmd_active: Indicate if UIC command is outstanding
> * @result: UIC command result
> * @done: UIC command completion
> */
> @@ -97,7 +96,6 @@ struct uic_command {
> u32 argument1;
> u32 argument2;
> u32 argument3;
> - int cmd_active;
> int result;
> struct completion done;
> };
> --
> 2.18.0