Re: [Sound-open-firmware] [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP

From: Pierre-Louis Bossart
Date: Fri Jun 12 2020 - 11:10:52 EST




On 6/12/20 7:24 AM, Kai Vehmanen wrote:
Hey Brent,

On Fri, 12 Jun 2020, Takashi Iwai wrote:

On Fri, 12 Jun 2020 12:50:48 +0200, Brent Lu wrote:

Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading
WP") from legacy HDA driver to fix the get response timeout issue.
Current SOF driver does not suffer from this issue because sync write
is enabled in hda_init. The issue will come back if the sync write is
disabled for some reason.

Signed-off-by: Brent Lu <brent.lu@xxxxxxxxx>

Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>

thanks, looks good now:

Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>

CI results initiated by Kai don't show any regression and change looks good so:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

Thanks Brent!