Re: [GIT PULL] sound fixes for 5.8-rc1

From: Pierre-Louis Bossart
Date: Fri Jun 12 2020 - 10:56:16 EST




On 6/12/20 9:46 AM, Mark Brown wrote:
On Fri, Jun 12, 2020 at 08:54:11AM -0500, Pierre-Louis Bossart wrote:

I think that those configuration errors are the problem and should be fixed
as a prerequisite to the removal of the duplication between
dpcm_playback/dpcm_capture/playback_only/capture_only. it may be painful and
generate noise for a while, but if we only throw a warning what are the odds
all those configuration errors will eventually be fixed?

Yeah, I'm kind of pessimistic about the likelyhood of people paying
attention to warnings.

If we need more time for validation on all platforms, then maybe we can
first relax the check for 5.8-rc1 as suggested by John, but re-add the
-EINVAL on -next to give a target of 5.9 with all configurations fixed?

I can't help feeling that it'd be postponing the inevitable, but perhaps
I'm being overly pessimistic here. The change did obviously go in quite
late though so it's not the worst idea if you want to send the patch?

I see patches from Srinivas to fix the issue reported by John, so maybe apply those patches first and if we see another issue on another platform we relax the check?