Re: [PATCH 1/3] usb: typec: Add QCOM PMIC typec detection driver

From: Wesley Cheng
Date: Fri Jun 12 2020 - 00:15:52 EST




On 6/9/2020 2:20 PM, Randy Dunlap wrote:
> On 6/9/20 1:58 PM, Wesley Cheng wrote:
>> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
>> index 559dd06..8de2520 100644
>> --- a/drivers/usb/typec/Kconfig
>> +++ b/drivers/usb/typec/Kconfig
>> @@ -73,6 +73,17 @@ config TYPEC_TPS6598X
>> If you choose to build this driver as a dynamically linked module, the
>> module will be called tps6598x.ko.
>>
>
> Hi,
> Please spell "Type-C" like all of the other drivers do.
>
>> +config TYPEC_QCOM_PMIC
>> + tristate "Qualcomm PMIC USB typec driver"
>> + depends on ARCH_QCOM
>> + help
>> + Driver for supporting role switch over the Qualcomm PMIC. This will
>> + handle the type C role and orientation detection reported by the QCOM
>> + PMIC if the PMIC has the capability to handle type C detection.
>> +
>> + It will also enable the VBUS output to connected devices when a
>> + DFP connection is made.
>> +
>> source "drivers/usb/typec/mux/Kconfig"
>>
>> source "drivers/usb/typec/altmodes/Kconfig"

Hi Randy,

Will do.

Thanks
>
>

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project