Re: [PATCH v2] powerpc: Remove inaccessible CMDLINE default

[Chris Packham]

On 11/06/20 5:46 pm, Christophe Leroy wrote:
>
>
> Le 11/06/2020 Ã 05:41, Chris Packham a ÃcritÂ:
>> Since commit cbe46bd4f510 ("powerpc: remove CONFIG_CMDLINE #ifdef mess")
>> CONFIG_CMDLINE has always had a value regardless of CONFIG_CMDLINE_BOOL.
>>
>> For example:
>>
>> Â $ make ARCH=powerpc defconfig
>> Â $ cat .config
>> Â # CONFIG_CMDLINE_BOOL is not set
>> Â CONFIG_CMDLINE=""
>>
>> When enabling CONFIG_CMDLINE_BOOL this value is kept making the 'default
>> "..." if CONFIG_CMDLINE_BOOL' ineffective.
>>
>> Â $ ./scripts/config --enable CONFIG_CMDLINE_BOOL
>> Â $ cat .config
>> Â CONFIG_CMDLINE_BOOL=y
>> Â CONFIG_CMDLINE=""
>>
>> Remove CONFIG_CMDLINE_BOOL and the inaccessible default.
>
> You also have to remove all CONFIG_CMDLINE_BOOL from the defconfigs

OK. I'll do so as a follow-up patch and send a v3.

>
> Christophe
>
>>
>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
>> Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxx>
>> ---
>> It took me a while to get round to sending a v2, for a refresher v1 
>> can be found here:
>>
>> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20190802050232.22978-1-chris.packham@xxxxxxxxxxxxxxxxxxx/ 
>>
>>
>> Changes in v2:
>> - Rebase on top of Linus's tree
>> - Fix some typos in commit message
>> - Add review from Christophe
>> - Remove CONFIG_CMDLINE_BOOL
>>
>> Â arch/powerpc/Kconfig | 6 +-----
>> Â 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 9fa23eb320ff..51abc59c3334 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -859,12 +859,8 @@ config PPC_DENORMALISATION
>> ÂÂÂÂÂÂÂ Add support for handling denormalisation of single precision
>>  values. Useful for bare metal only. If unsure say Y here.
>> Â -config CMDLINE_BOOL
>> -ÂÂÂ bool "Default bootloader kernel arguments"
>> -
>> Â config CMDLINE
>> -ÂÂÂ string "Initial kernel command string" if CMDLINE_BOOL
>> -ÂÂÂ default "console=ttyS0,9600 console=tty0 root=/dev/sda2" if 
>> CMDLINE_BOOL
>> +ÂÂÂ string "Initial kernel command string"
>> ÂÂÂÂÂ default ""
>> ÂÂÂÂÂ help
>> ÂÂÂÂÂÂÂ On some platforms, there is currently no way for the boot 
>> loader to
>>