Re: [PATCH v2 2/2] perf tools: Improve exception handling in two functions of perf events parser

From: Markus Elfring
Date: Thu Jun 11 2020 - 15:09:50 EST

Next message: Lee Jones: "[PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes"
Previous message: kernel test robot: "safexcel.c:undefined reference to `devm_platform_ioremap_resource'"
In reply to: Chen Wandun: "[PATCH next v2 2/2] perf tools: fix potential memleak in perf events parser"
Next in thread: Chen Wandun: "[PATCH next v2 1/2] perf tools: fix potential memleak in perf events parser"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Fix potential memory leak. Function new_term may return error, so
> it is need to free memory when the return value is negative.

How do you think about a wording variant like the following?

Add jump targets so that a configuration object and a duplicated string
are released after a call of the function âstrdupâ or ânew_termâ failed.

Regards,
Markus

Next message: Lee Jones: "[PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes"
Previous message: kernel test robot: "safexcel.c:undefined reference to `devm_platform_ioremap_resource'"
In reply to: Chen Wandun: "[PATCH next v2 2/2] perf tools: fix potential memleak in perf events parser"
Next in thread: Chen Wandun: "[PATCH next v2 1/2] perf tools: fix potential memleak in perf events parser"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]