Re: [PATCH 7/8] drm/msm/dpu: add SM8150 to hw catalog

[Jonathan Marek]

On 6/11/20 10:37 AM, Dmitry Baryshkov wrote:
> On 26/05/2020 06:22, Jonathan Marek wrote:
> > This brings up basic video mode functionality for SM8150 DPU. Command 
> > mode
> > and dual mixer/intf configurations are not working, future patches will
> > address this. Scaler functionality and multiple planes is also untested.
> >
> > Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> > ---
> > Â .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.cÂÂÂ | 147 ++++++++++++++++++
> > Â drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.hÂÂ |ÂÂ 2 +
> > Â 2 files changed, 149 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c 
> > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > index 1e64fa08c219..f99622870676 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > @@ -90,6 +90,23 @@ static const struct dpu_caps sc7180_dpu_caps = {
> > ÂÂÂÂÂ .pixel_ram_size = DEFAULT_PIXEL_RAM_SIZE,
> > Â };
> > +static const struct dpu_caps sm8150_dpu_caps = {
> > +ÂÂÂ .max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> > +ÂÂÂ .max_mixer_blendstages = 0xb,
> > +ÂÂÂ .max_linewidth = 4096,
> > +ÂÂÂ .qseed_type = DPU_SSPP_SCALER_QSEED3,
> > +ÂÂÂ .smart_dma_rev = DPU_SSPP_SMART_DMA_V2_5,
>
> It seems you missed sending a patch adding support for 
> DPU_SSPP_SMART_DMA_V2_5. Could you please point to it?

There are no other changes related to that, the driver never checks 
smart_dma_rev and the correct version number is only set for when the 
driver supports it (if ever).