Re: [PATCH v2] sched/fair: fix nohz next idle balance

[Peter Zijlstra]

On Thu, Jun 11, 2020 at 03:12:11PM +0100, Valentin Schneider wrote:
> 
> On 09/06/20 13:37, Vincent Guittot wrote:
> > With commit:
> >   'b7031a02ec75 ("sched/fair: Add NOHZ_STATS_KICK")'
> > rebalance_domains of the local cfs_rq happens before others idle cpus have
> > updated nohz.next_balance and its value is overwritten.
> >
> > Move the update of nohz.next_balance for other idles cpus before balancing
> > and updating the next_balance of local cfs_rq.
> >
> > Also, the nohz.next_balance is now updated only if all idle cpus got a
> > chance to rebalance their domains and the idle balance has not been aborted
> > because of new activities on the CPU. In case of need_resched, the idle
> > load balance will be kick the next jiffie in order to address remaining
> > ilb.
> >
> > Reported-by: Peng Liu <iwtbavbm@xxxxxxxxx>
> > Signed-off-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> 
> FWIW:
> Reviewed-by: Valentin Schneider <valentin.schneider@xxxxxxx>
> 
> Do we want a Fixes: tag for this? I'm thinking
> b7031a02ec75 ("sched/fair: Add NOHZ_STATS_KICK")

Done, thanks!