Re: [PATCH v2] usb: dwc3: Add support for VBUS power control

[Mike Looijmans]

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@xxxxxxxxxxxxxxxxx
W: www.topicproducts.com

Please consider the environment before printing this e-mail
On 10-06-2020 22:22, Rob Herring wrote:
> On Wed, Jun 03, 2020 at 02:09:15PM +0200, Mike Looijmans wrote:
> > Support VBUS power control using regulator framework. Enables the regulator
> > while the port is in host mode.
> >
> > Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx>
> > ---
> > v2: Add missing devm_regulator_get call which got lost during rebase
> >
> >   .../devicetree/bindings/usb/dwc3.txt          |  1 +
> >   drivers/usb/dwc3/core.c                       | 34 ++++++++++++++-----
> >   drivers/usb/dwc3/core.h                       |  4 +++
> >   drivers/usb/dwc3/drd.c                        |  6 ++--
> >   4 files changed, 33 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> > index 9946ff9ba735..56bc3f238e2d 100644
> > --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> > @@ -37,6 +37,7 @@ Optional properties:
> >    - phys: from the *Generic PHY* bindings
> >    - phy-names: from the *Generic PHY* bindings; supported names are "usb2-phy"
> >   	or "usb3-phy".
> > + - vbus-supply: Regulator handle that provides the VBUS power.
> Does the DWC3 block require Vbus to power itself? Doubtful. This
> belongs in a usb-connector node. If the DWC3 driver wants to get the
> Vbus supply, it can fetch it from that node.
>
> Rob

Ah, now I understand. There's a vbus-supply in the connector in newer 
kernel versions than the one I have to test with. It'll have to wait 
until I've been able to upgrade the kernel version for this board.


--
Mike Looijmans