Re: [PATCH V2 1/2] mtd: rawnand: qcom: remove write to unavailable register

From: Sivaprakash Murugesan
Date: Thu Jun 11 2020 - 00:30:40 EST


Hi Miquel,

On 6/9/2020 7:32 PM, Miquel Raynal wrote:
Hi Sivaprakash,

Sivaprakash Murugesan <sivaprak@xxxxxxxxxxxxxx> wrote on Tue, 9 Jun
2020 16:40:55 +0530:

SFLASHC_BURST_CFG register is not available on all ipq nand platforms,
it is available only on ipq8064 devices and the nand controller works
without configuring these registers in this platform, so register write
to this can be removed.
Maybe it works because the bootloader is setting the register itself.
What if you use a different bootloader, or the same bootloader without
NAND support?

I don't think this is a proper fix, you should instead have a different
compatible if the IP is not the same and depending on this compatible
do the write, or not.

I understand your point, will fix this in next patch.

Thanks,

Siva

Thanks,
MiquÃl