Re: [PATCH] checkpatch: ignore CamelCase for inttypes.h format specifiers

From: Scott Branden
Date: Wed Jun 10 2020 - 17:48:15 EST




On 2020-06-10 2:09 p.m., Joe Perches wrote:
On Wed, 2020-06-10 at 13:33 -0700, Scott Branden wrote:
Ignore CamelCase for inttypes.h for fixed integer types format specifiers.
(ex. PRIx32 for uint32_t).
Personally, I don't like those.
Checkpatch is run against a lot of code outside of the linux kernel but following linux coding style.
There is nothing personal about this, they are the format specifiers in inttypes.h for fixed width types .

Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
---
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 899e380782c0..9fa90457b270 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5157,6 +5157,8 @@ sub process {
$var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
#Ignore Page<foo> variants
$var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+#Ignore inttypes.h scanf/printf format specifiers for fixed size integer types
+ $var !~ /^(?:PRI|SCN)[dxoui](8|16|32|64|PTR|MAX)?$/ &&
#Ignore SI style variants like nS, mV and dB
#(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE)
$var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&