Re: [PATCH v2 0/2] media: staging: rkisp1: allow simultaneous streaming from multiple capture devices

From: Tomasz Figa
Date: Wed Jun 10 2020 - 12:37:21 EST


On Mon, Mar 16, 2020 at 06:00:42PM -0300, Helen Koike wrote:
> Hi,
>
> This series adds support for simultaneous streaming from both capture
> devices (rkisp1_selfpath and rkisp1_mainpath).
>
> It depends on the following series for multistream to work properly, but
> it doesn't mean it can't be merged before:
>
> "media: add v4l2_pipeline_stream_{enable,disable} helpers"
> https://patchwork.linuxtv.org/cover/62233/
>
> And it is also available at:
>
> https://gitlab.collabora.com/koike/linux/tree/rockchip/isp/multistream
>
> Patch 1/2 fixes return error handling from pm functions, which was
> preventing the second stream to start.
>
> Patch 2/2 serializes start/stop streaming calls, since they both
> and modify shared variables.
>
> Changes in v2:
> - Rebased on media/master
> - Removed the following patch from the series:
> "media: staging: rkisp1: do not call s_stream if the entity is still in use"
> It was replaced by "media: add v4l2_pipeline_stream_{enable,disable} helpers"
> https://patchwork.linuxtv.org/cover/62233/
>

For the whole series:

Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>

Best regards,
Tomasz