Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

From: Geert Uytterhoeven
Date: Wed Jun 10 2020 - 07:59:39 EST


Hi Mark,

On Wed, Jun 10, 2020 at 1:08 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Tue, Jun 09, 2020 at 09:54:13PM +0100, Lad Prabhakar wrote:
> > Document RZ/G1H (R8A7742) SoC bindings.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> To repeat my previous feedback I'd expect a driver update as well.

No driver update is needed.

Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml says:

compatible:
oneOf:
- items:
- enum:
- renesas,msiof-r8a7742 # RZ/G1H
...
- const: renesas,rcar-gen2-msiof # generic R-Car Gen2 and RZ/G1
# compatible device

drivers/spi/spi-sh-msiof.c matches against "renesas,rcar-gen2-msiof".

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds