Re: [PATCH] efi/libstub: Fix build error with libstub

[Zhenzhong Duan]

On Wed, Jun 10, 2020 at 5:10 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
>
> On Wed, 10 Jun 2020 at 10:59, Nathan Chancellor
> <natechancellor@xxxxxxxxx> wrote:
> >
> > On Wed, Jun 10, 2020 at 03:14:46PM +0800, Zhenzhong Duan wrote:
> > > Got below error during build:
...
> > > diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
> > > index cce4a74..25e5d02 100644
> > > --- a/drivers/firmware/efi/libstub/Makefile
> > > +++ b/drivers/firmware/efi/libstub/Makefile
> > > @@ -6,7 +6,7 @@
> > >  # enabled, even if doing so doesn't break the build.
> > >  #
> > >  cflags-$(CONFIG_X86_32)              := -march=i386
> > > -cflags-$(CONFIG_X86_64)              := -mcmodel=small
> > > +cflags-$(CONFIG_X86_64)              := -mcmodel=small -maccumulate-outgoing-args
> >
> > This will need a cc-option call if this patch is necessary because clang
> > does not support this flag.
> >
> > clang-11: error: unknown argument: '-maccumulate-outgoing-args'
> >
>
> A fix was already sent for this
>
> https://lore.kernel.org/bpf/20200605150638.1011637-1-nivedita@xxxxxxxxxxxx/
>
> which does the right thing here.
Ah, so I'm late again. Not clear if there is easy way to check queued
patches for upstream..

Regards
Zhenzhong